Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CSV File Scan Operator #3217

Merged
merged 7 commits into from
Jan 20, 2025
Merged

Fix CSV File Scan Operator #3217

merged 7 commits into from
Jan 20, 2025

Conversation

MiuMiuMiue
Copy link
Collaborator

@MiuMiuMiue MiuMiuMiue commented Jan 16, 2025

Fix the issue #3055 that CSV Scan an empty file would result in error.

@MiuMiuMiue MiuMiuMiue self-assigned this Jan 16, 2025
@MiuMiuMiue MiuMiuMiue changed the title Execute CSV File Scan operator when csv file is empty Fix CSV File Scan Operator Jan 16, 2025
@MiuMiuMiue MiuMiuMiue added the bug label Jan 16, 2025
@MiuMiuMiue MiuMiuMiue requested a review from bobbai00 January 16, 2025 06:27
Copy link
Collaborator

@bobbai00 bobbai00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please simplify the code as suggested

@MiuMiuMiue MiuMiuMiue requested a review from bobbai00 January 18, 2025 00:37
Copy link
Collaborator

@bobbai00 bobbai00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiuMiuMiue MiuMiuMiue merged commit 586496c into master Jan 20, 2025
8 checks passed
@MiuMiuMiue MiuMiuMiue deleted the Zhe-empty-csv-file branch January 20, 2025 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants